Skip to content

Properly retry download when fabric installer is invalid #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Properly retry download when fabric installer is invalid #3617

merged 1 commit into from
Aug 13, 2025

Conversation

@itzg
Copy link
Owner

@itzg itzg commented Aug 13, 2025 •
edited
Loading

@itzg itzg merged commit 9d2cd14 into master Aug 13, 2025
5 checks passed
@itzg itzg deleted the itzg-patch-4 branch August 13, 2025 11:43
@ewized
Copy link

ewized commented Aug 13, 2025 •
edited
Loading

Not sure if its this commit or not but :latest docker container that seams to get stuck on. For the time being I had to roll back to the :stable tag.

[init] Changing uid of minecraft to 99
[init] Changing gid of minecraft to 98
[init] Running as uid=99 gid=98 with /data as 'drwxr-x--- 21 99 1000 40 Aug  8 13:00 /data'
[init] Image info: buildtime=2025-08-09T22:30:04.083Z,version=2025.8.1,revision=0d834dd99221443d97f84308b10c62f4f880d66d
[mc-image-helper] 16:01:45.058 INFO  : Requested force synchronize of All the Mods 10-4.4

using

TYPE: AUTO_CURSEFORGE
CF_API_KEY: ${CF_API_KEY}
CF_PAGE_URL: https://www.curseforge.com/minecraft/modpacks/all-the-mods-10/files/6763727
CF_FORCE_SYNCHRONIZE: true

@itzg
Copy link
Owner Author

itzg commented Aug 13, 2025

I see what you mean. With DEBUG=true it seems to be stuck during an initial download

2025-08-13T16:50:27.467529718Z [mc-image-helper] 16:50:27.467 DEBUG : Modpack file retrieval: status=DOWNLOADING uri=https://edge.forgecdn.net/files/6826/503/All%20the%20Mods%2010-4.5.zip file=/tmp/curseforge-modpack15399574173297610245.zip
2025-08-13T16:50:27.467613218Z [mc-image-helper] 16:50:27.467 DEBUG : FILE FETCH: uri=https://mediafilez.forgecdn.net/files/6826/503/All%20the%20Mods%2010-4.5.zip headers=[user-agent: itzg/mc-image-helper/1.48.7 (cmd=install-curseforge), x-fetch-session: 971a47a2-f0dd-4f1b-85e9-31f8f441795d, x-api-key: [redacted], host: mediafilez.forgecdn.net, accept: */*]

itzg added a commit that referenced this pull request Aug 13, 2025
@itzg
Revert "Properly retry download when fabric installer is invalid (#3617…
2c49b87 
…)"

This reverts commit 9d2cd14.
@itzg itzg mentioned this pull request Aug 13, 2025
Merged
@itzg
Copy link
Owner Author

itzg commented Aug 13, 2025

...it does seem to proceed after a while, but reverted the change for now so I can investigate further.

@itzg itzg mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itzg @ewized